Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix set session variable make tidb_snapshot unwork #28677

Merged
merged 4 commits into from
Oct 9, 2021

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Oct 9, 2021

Signed-off-by: yisaer disxiaofei@163.com

What problem does this PR solve?

tidb_snapshot won't work after setting any session variable

What is changed and how it works?

fix set session variable make tidb_snapshot unwork

Check List

Tests

  • Unit test

Release note

Fix the bug that setting any session variable will make `tidb_snapshot` unwork.

Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from xhebox October 9, 2021 04:00
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 9, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2021
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 9, 2021
@jackysp
Copy link
Member

jackysp commented Oct 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fced8fd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2021
@ti-chi-bot ti-chi-bot merged commit 417c735 into pingcap:master Oct 9, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 9, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #28682

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 9, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #28683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants