session: migrate test-infra to testify for isolation_test.go #29018
Conversation
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
This closes pingcap#28324 . Signed-off-by: tison <wander4096@gmail.com>
session/session_test.go
Outdated
|
|
||
| func (s *testSessionSuiteBase) SetUpSuite(c *C) { | ||
| testleak.BeforeTest() | ||
| func createTestSuite(assert func(error), s *testSessionSuiteBase) *testSessionSuiteBase { |
There was a problem hiding this comment.
temporary work around, will clean up after session tests migrated.
|
/cc @morgo @djshow832 |
Signed-off-by: tison <wander4096@gmail.com>
ti-chi-bot
added
size/XXL
session/isolation_test.go
Outdated
| wg.Add(1) | ||
| go func() { | ||
| func SubTestP0DirtyWrite(s *testSessionSuiteBase) func(*testing.T) { | ||
| return func(t *testing.T) { |
There was a problem hiding this comment.
These are almost indents.
Signed-off-by: tison <wander4096@gmail.com>
|
ping @morgo @djshow832 The CI failure cannot reproduce locally, can you please help on looking into it? |
|
It seems related to pingcap-qe/ci settings. |
Signed-off-by: tison <wander4096@gmail.com>
|
Sorry I cannot handle the |
This closes #28324 .
Release note