Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: lazy the subquery-more-than-1-row error after the insert duplicate is actually triggered #29270

Merged
merged 12 commits into from
Nov 11, 2021

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Oct 30, 2021

Signed-off-by: ailinkid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #29260

What is changed and how it works?

The expression rewriter in the build-plan phase will throw the subquery-more-than-1-row error regardless whatever the insert statement has triggered the duplicate cases.

We choose to store the intermediate error down with the column assignment, and throw it out when the insert duplicate logic is called essentially

Check List

Tests

  • Unit test
  • Integration test

Release note

Statements in the format `INSERT INTO t2 (a) VALUES (1) ON DUPLICATE KEY UPDATE a= (SELECT b FROM source);` now evaluate the subquery lazily. This helps improve MySQL compatibility.

… actually triggered

Signed-off-by: ailinkid <314806019@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2021
Signed-off-by: ailinkid <314806019@qq.com>
Signed-off-by: ailinkid <314806019@qq.com>
Signed-off-by: ailinkid <314806019@qq.com>
planner/core/planbuilder.go Outdated Show resolved Hide resolved
planner/core/planbuilder.go Show resolved Hide resolved
planner/core/resolve_indices.go Outdated Show resolved Hide resolved
AilinKid and others added 5 commits November 1, 2021 15:54
Co-authored-by: Yiding Cui <winoros@gmail.com>
Co-authored-by: Yiding Cui <winoros@gmail.com>
Signed-off-by: ailinkid <314806019@qq.com>
@morgo
Copy link
Contributor

morgo commented Nov 2, 2021

/run-check_dev_2

@AilinKid
Copy link
Contributor Author

AilinKid commented Nov 2, 2021

/run-all-tests

@AilinKid AilinKid requested a review from winoros November 4, 2021 09:56
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 5, 2021
@morgo
Copy link
Contributor

morgo commented Nov 9, 2021

LGTM (nonbinding; I will leave for someone on the planner team to review.)

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2021
@winoros
Copy link
Member

winoros commented Nov 11, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 48fdd57

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2021
@ti-chi-bot
Copy link
Member

@AilinKid: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR 1242 (21000): Subquery returns more than 1 row (insert_update.test)
5 participants