Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix a bug caused by cast function signature wrong in aggregation push down (#28805) #29345

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 2, 2021

cherry-pick #28805 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/29345

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/29345:release-5.2-a18977a93b69

What problem does this PR solve?

Issue Number: close #28804

Problem Summary:

What is changed and how it works?

Remove the special handle of cast function in ColumnSubstituteImpl

The bug is caused by this:

Before ColumnSubstitute, the function signature of cast(floor(hour(ts) / 4) as char) is cast(Int -> Varstring) ...
Then, the ColumnSubstitute will substitute the column ts of expression floor(hour(ts) / 4)
After that, the expression floor(hour(ts) / 4) signature changed, it's return type is not Int any more.
Expression floor(hour(ts) / 4) returns Decimal instead.

But the signature of cast() function is still cast(Int -> Varstring), so the cast expect floor(hour(ts) / 4) to return Int and the later returns Decimal, the error is throw finally.

What's Changed:

Remove the special handle of the cast function.

How it Works:

The bug is caused by the special handle of the Cast function.
Its function args are re-generated (signature re-calculated), but the Cast function it self does not refresh.
So the signature mismatch...

OK, "why the signature change from Int to Decimal" is another story, it's caused by the wrong Flen and that's another big issue.
I'm not meant to solve it here.

Check List

Tests

  • [] Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix `ColumnSubstitute` cause wrong signature of the Cast() function, this bug could led TiDB return "baseBuiltinFunc.vecEvalInt() should never be called" error in some aggregation push down scenario.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 2, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 2, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 2, 2021
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.2-cherry-pick type/bugfix This PR fixes a bug. labels Nov 2, 2021
@ti-srebot ti-srebot added this to the v5.2.2 milestone Nov 2, 2021
@ti-srebot
Copy link
Contributor Author

@tiancaiamao you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2021
@VelocityLight
Copy link

This pull request is closed because it's related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.2-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants