planner: make clear for MaybeOverOptimized4PlanCache

expression/builtin_compare.go

@@ -1465,6 +1465,9 @@ func (c *compareFunctionClass) refineArgs(ctx sessionctx.Context, args []Express
 		} else {
 			return args
 		}
+	} else if ctx.GetSessionVars().StmtCtx.MaybeOverOptimized4PlanCache {
+		// We should remove the mutable constant for correctness, because it's value maybe changed.
+		RemoveMutableConst(ctx, args)
 	}
 	// int non-constant [cmp] non-int constant
 	if arg0IsInt && !arg0IsCon && !arg1IsInt && arg1IsCon {

expression/util.go

@@ -920,12 +920,7 @@ func ContainCorrelatedColumn(exprs []Expression) bool {
 // TODO: Do more careful check here.
 func MaybeOverOptimized4PlanCache(ctx sessionctx.Context, exprs []Expression) bool {
 	// If we do not enable plan cache, all the optimization can work correctly.
-	if !ctx.GetSessionVars().StmtCtx.UseCache {
-		return false
-	}
-	if ctx.GetSessionVars().StmtCtx.MaybeOverOptimized4PlanCache {
-		// If the current statement can not be cached. We should remove the mutable constant.
-		RemoveMutableConst(ctx, exprs)
+	if !ctx.GetSessionVars().StmtCtx.UseCache || ctx.GetSessionVars().StmtCtx.MaybeOverOptimized4PlanCache {
 		return false
 	}
 	return containMutableConst(ctx, exprs)

planner/core/expression_rewriter.go

@@ -1459,6 +1459,9 @@ func (er *expressionRewriter) inToExpression(lLen int, not bool, tp *types.Field
 					} else {
 						continue
 					}
+				} else if er.sctx.GetSessionVars().StmtCtx.MaybeOverOptimized4PlanCache {
+					// We should remove the mutable constant for correctness, because it's value maybe changed.
+					expression.RemoveMutableConst(er.sctx, []expression.Expression{c})
 				}
 				args[i], isExceptional = expression.RefineComparedConstant(er.sctx, *leftFt, c, opcode.EQ)
 				if isExceptional {