Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl/ddl_test.go: refactor testNewDDLAndStart to return error #29964

Merged
merged 6 commits into from
Nov 22, 2021
Merged

ddl/ddl_test.go: refactor testNewDDLAndStart to return error #29964

merged 6 commits into from
Nov 22, 2021

Commits on Nov 21, 2021

  1. Refactor testNewDDLAndStart to return error 

    By returning an error instead of performing assertion, it allows the calleer to decide how to handle the errors.

This is also helpful when the caller wants more flexibility with the assertion (using check Vs require).
    @clovis1122
    clovis1122 committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    3c72a5d View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Merge branch 'master' into refactor-util-functions

    @ti-chi-bot
    ti-chi-bot committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    4780efc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into refactor-util-functions

    @ti-chi-bot
    ti-chi-bot committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    439416f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into refactor-util-functions

    @ti-chi-bot
    ti-chi-bot committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    3a3fe39 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into refactor-util-functions

    @ti-chi-bot
    ti-chi-bot committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    0ecc54a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into refactor-util-functions

    @ti-chi-bot
    ti-chi-bot committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    006ef2e View commit details
    Browse the repository at this point in the history