Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: migrate test-infra to testify for enforce_mpp_test.go #32479

Merged
merged 3 commits into from
Feb 19, 2022
Merged

planner/core: migrate test-infra to testify for enforce_mpp_test.go #32479

merged 3 commits into from
Feb 19, 2022

Conversation

tisonkun
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #28389

Release note

None

@tisonkun
planner/core: migrate test-infra to testify for enforce_mpp_test.go
b1cc288 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 19, 2022 •
edited
Loading

/cc @hawkingrei @LittleFall

@sre-bot
Copy link
Contributor

sre-bot commented Feb 19, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e0a152a343f860f4bcf1150d426083095be7f17f

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 19, 2022
@tisonkun tisonkun requested review from LittleFall and removed request for Little-Wallace February 19, 2022 09:07
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 19, 2022
@tisonkun
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e0a152a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 19, 2022
@tisonkun
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 36a1f84 into pingcap:master Feb 19, 2022
@tisonkun tisonkun deleted the issue-28389 branch February 19, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@LittleFall LittleFall LittleFall approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for planner/core/enforce_mpp_test.go
5 participants
@tisonkun @ti-chi-bot @sre-bot @hawkingrei @LittleFall