Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: migrate test-infra to testify for explain_unit_test.go #32706

Merged
merged 4 commits into from
Mar 2, 2022
Merged

executor: migrate test-infra to testify for explain_unit_test.go #32706

merged 4 commits into from
Mar 2, 2022

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Mar 1, 2022

What problem does this PR solve?

Issue Number: close #28579

None

@tisonkun
executor: migrate test-infra to testify for explain_unit_test.go
51a4a0d 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 1, 2022

/cc @hi-rustin @hawkingrei

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 1, 2022

/cc @xhebox

@ti-chi-bot ti-chi-bot requested a review from xhebox March 1, 2022 12:41
@tisonkun
gofmt
b5d907c 
Signed-off-by: tison <wander4096@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e75b28fb1152d897e4a526e8a74da2ae0c40632e

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 1, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 1, 2022

/merge

@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 1, 2022

/merge

@tisonkun tisonkun added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 1, 2022

/merge

@tisonkun tisonkun added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 1, 2022

cc @hi-rustin @Mini256 it seems @ti-chi-bot just doesn't work...

@hawkingrei hawkingrei requested a review from morgo March 1, 2022 15:52
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e75b28f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 2, 2022

/run-mysql-test

1 similar comment
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 2, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 61769a4 into pingcap:master Mar 2, 2022
@tisonkun tisonkun deleted the issue-28579 branch April 13, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@xhebox xhebox Awaiting requested review from xhebox

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for explain_unit_test.go
5 participants
@tisonkun @ti-chi-bot @sre-bot @hawkingrei @Rustin170506