Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: outer merge join cannot keep the prop of its inner child #33359

Merged
merged 3 commits into from
Mar 24, 2022
Merged

planner: outer merge join cannot keep the prop of its inner child #33359

merged 3 commits into from
Mar 24, 2022

Conversation

winoros
Copy link
Member

@winoros winoros commented Mar 23, 2022

What problem does this PR solve?

Issue Number: close #33042

Problem Summary:

If the merge join is outer join. We cannot make sure that its output can keep the input order of the inner side.

What is changed and how it works?

Reject the mentioned case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@winoros winoros force-pushed the merge-join-right-prop-cannot-pass branch from aeeb88a to 4ed6fbd Compare March 23, 2022 16:01
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • XuHuaiyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2022
fixdb
fixdb reviewed Mar 23, 2022
View reviewed changes
planner/core/exhaust_physical_plans.go
}
if p.JoinType == RightOuterJoin && hasLeftColInProp {
return nil
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we support full outer join?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have that

AilinKid
AilinKid approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor

sre-bot commented Mar 24, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1ad6dbd702811a94709ccb6e7d32d38878eac268

XuHuaiyu
XuHuaiyu approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2022
@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Mar 24, 2022
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a0d2cac

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022
@ti-chi-bot ti-chi-bot merged commit 1287eab into pingcap:master Mar 24, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 24, 2022
@winoros @ti-srebot
cherry pick pingcap#33359 to release-4.0
a33d7f3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #33369

@winoros winoros deleted the merge-join-right-prop-cannot-pass branch March 24, 2022 03:45
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 24, 2022
@winoros @ti-srebot
cherry pick pingcap#33359 to release-5.0
342ad47 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33371

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 24, 2022
@winoros @ti-srebot
cherry pick pingcap#33359 to release-5.1
f4ce718 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33372

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 24, 2022
@winoros @ti-srebot
cherry pick pingcap#33359 to release-5.2
8e7ebe3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33373

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 24, 2022
@winoros @ti-srebot
cherry pick pingcap#33359 to release-5.3
5742215 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33374

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 24, 2022
@winoros @ti-srebot
cherry pick pingcap#33359 to release-5.4
a8b6ff6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33375

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 24, 2022
@winoros @ti-srebot
cherry pick pingcap#33359 to release-6.0
71ccc06 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33376

ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2022
@ti-srebot
planner: outer merge join cannot keep the prop of its inner child (#3…
533a7f6 
…3359) (#33376)

close #33042
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2022
@ti-srebot
planner: outer merge join cannot keep the prop of its inner child (#3…
ae5b88b 
…3359) (#33373)

close #33042
ti-chi-bot pushed a commit that referenced this pull request Apr 27, 2022
@ti-srebot
planner: outer merge join cannot keep the prop of its inner child (#3…
2a86e88 
…3359) (#33375)

close #33042
ti-chi-bot pushed a commit that referenced this pull request Jun 17, 2022
@ti-srebot
planner: outer merge join cannot keep the prop of its inner child (#3…
61d09f4 
…3359) (#33374)

close #33042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fixdb fixdb fixdb left review comments

@AilinKid AilinKid AilinKid approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge Join executed incorrect resultset which returned empty resultset
7 participants
@winoros @ti-chi-bot @sre-bot @XuHuaiyu @ti-srebot @fixdb @AilinKid