Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statscache: improve stats cache benchmark #45605

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 27, 2023

What problem does this PR solve?

Issue Number: ref #45281

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 27, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #45605 (5d87364) into master (64be9ec) will increase coverage by 0.1655%.
Report is 7 commits behind head on master.
The diff coverage is 96.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45605        +/-   ##
================================================
+ Coverage   73.2187%   73.3842%   +0.1655%     
================================================
  Files          1270       1273         +3     
  Lines        389940     391820      +1880     
================================================
+ Hits         285509     287534      +2025     
+ Misses        86127      85909       -218     
- Partials      18304      18377        +73     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3759% <96.0000%> (+0.1572%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0526% <ø> (+0.0108%) ⬆️
br 52.1554% <ø> (+0.0336%) ⬆️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-27 09:03:40.312099632 +0000 UTC m=+431562.906630619: ☑️ agreed by xhebox.
  • 2023-07-27 09:15:30.806057035 +0000 UTC m=+432273.400588021: ☑️ agreed by qw4990.

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 8560d66 into pingcap:master Jul 27, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants