ddl, session: using table ID instead of partition ID when calling SplitRegions (#46156)

[ti-chi-bot]

This is an automated cherry-pick of #46156

What problem does this PR solve?

Issue Number: close #46135

Problem Summary:

tidb/ddl/split_region.go

Lines 44 to 46 in 95b4dcc

	for _, def := range parts {
	regionIDs = append(regionIDs, SplitRecordRegion(ctxWithTimeout, store, def.ID, scatter))
	}

tidb/ddl/split_region.go

Lines 121 to 123 in 95b4dcc

	func SplitRecordRegion(ctx context.Context, store kv.SplittableStore, tableID int64, scatter bool) uint64 {
	tableStartKey := tablecodec.GenTablePrefix(tableID)
	regionIDs, err := store.SplitRegions(ctx, [][]byte{tableStartKey}, scatter, &tableID)

https://github.com/tikv/pd/blob/346e7716e2598dfba2db6afa73c3731e15449f49/client/client.go#L1403-L1409

	req := &pdpb.ScatterRegionRequest{
		Header:         c.requestHeader(),
		Group:          options.group,
		RegionsId:      regionsID,
		RetryLimit:     options.retryLimit,
		SkipStoreLimit: options.skipStoreLimit,
	}

As you can see from the above code, the tableID passed to SplitRegions is the ID of the partitioned table. And we use tableID as Group pass to PD. So different partition ID uses different group ID in a table which makes the split region is uneven.

What is changed and how it works?

In the partition table, we use table ID as a group ID to pass PD.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

tidb> select @@global.tidb_scatter_region;
+------------------------------+
| @@global.tidb_scatter_region |
+------------------------------+
|                            1 |
+------------------------------+
1 row in set (0.00 sec)
create table test.t1(id int,b int) shard_row_id_bits=4 partition by hash(id) partitions 2000; 

Before this PR:

After this PR:

• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@1d77dfd). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-6.5     #46163   +/-   ##
================================================
  Coverage               ?   73.6545%           
================================================
  Files                  ?       1083           
  Lines                  ?     347730           
  Branches               ?          0           
================================================
  Hits                   ?     256119           
  Misses                 ?      75165           
  Partials               ?      16446           

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [crazycs520,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-08-17 02:37:56.844368553 +0000 UTC m=+771441.393384540: ☑️ agreed by crazycs520.
• 2023-08-17 02:58:21.44713577 +0000 UTC m=+772665.996151774: ☑️ agreed by tangenta.