ddl, session: using table ID instead of partition ID when calling SplitRegions | tidb-test=pr/2145 #46173

zimulala · 2023-08-17T03:12:46Z

This is an automated cherry-pick of #46156

What problem does this PR solve?

Issue Number: close #46135

Problem Summary:

Lines 44 to 46 in 95b4dcc

    
           for _, def := range parts { 
        
           	regionIDs = append(regionIDs, SplitRecordRegion(ctxWithTimeout, store, def.ID, scatter)) 
        
           }

tidb/ddl/split_region.go

Lines 121 to 123 in 95b4dcc

    
           func SplitRecordRegion(ctx context.Context, store kv.SplittableStore, tableID int64, scatter bool) uint64 { 
        
           	tableStartKey := tablecodec.GenTablePrefix(tableID) 
        
           	regionIDs, err := store.SplitRegions(ctx, [][]byte{tableStartKey}, scatter, &tableID)

https://github.com/tikv/pd/blob/346e7716e2598dfba2db6afa73c3731e15449f49/client/client.go#L1403-L1409

	req := &pdpb.ScatterRegionRequest{
		Header:         c.requestHeader(),
		Group:          options.group,
		RegionsId:      regionsID,
		RetryLimit:     options.retryLimit,
		SkipStoreLimit: options.skipStoreLimit,
	}

As you can see from the above code, the tableID passed to SplitRegions is the ID of the partitioned table. And we use tableID as Group pass to PD. So different partition ID uses different group ID in a table which makes the split region is uneven.

What is changed and how it works?

In the partition table, we use table ID as a group ID to pass PD.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

tidb> select @@global.tidb_scatter_region;
+------------------------------+
| @@global.tidb_scatter_region |
+------------------------------+
|                            1 |
+------------------------------+
1 row in set (0.00 sec)
create table test.t1(id int,b int) shard_row_id_bits=4 partition by hash(id) partitions 2000;

Before this PR:

After this PR:

No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…itRegions

tiprow · 2023-08-17T03:13:12Z

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala · 2023-08-17T03:23:18Z

/retest-required

tiprow · 2023-08-17T03:23:50Z

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala · 2023-08-17T03:32:34Z

/retest-required

tiprow · 2023-08-17T03:33:51Z

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala · 2023-08-17T03:38:25Z

/test mysql-test

tiprow · 2023-08-17T03:38:56Z

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala · 2023-08-17T03:54:25Z

/retest-required

tiprow · 2023-08-17T03:54:56Z

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala · 2023-08-17T04:01:46Z

/retest-required

tiprow · 2023-08-17T04:02:19Z

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala · 2023-08-17T05:55:07Z

/retest-required

tiprow · 2023-08-17T05:55:38Z

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-08-17T06:03:35Z

@crazycs520: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala · 2023-08-17T06:15:29Z

/retest-required

tiprow · 2023-08-17T06:16:03Z

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala · 2023-08-17T06:18:12Z

/ok-to-test

zimulala · 2023-08-17T06:43:27Z

/test mysql-test tidb-test=pr/2145

tiprow · 2023-08-17T06:44:02Z

@zimulala: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

In response to this:

/test mysql-test tidb-test=pr/2145

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala · 2023-08-17T06:50:52Z

/test mysql-test tidb-test=pr/2145

tiprow · 2023-08-17T06:51:28Z

@zimulala: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

In response to this:

/test mysql-test tidb-test=pr/2145

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala · 2023-08-17T06:52:54Z

/test mysql-test tidb-test=pr/2145

tiprow · 2023-08-17T06:53:31Z

@zimulala: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

In response to this:

/test mysql-test tidb-test=pr/2145

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala · 2023-08-17T07:04:44Z

/test mysql-test

tiprow · 2023-08-17T07:05:14Z

@zimulala: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-08-17T07:14:24Z

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20230425-v6.5.2@ab110b5). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

@@                       Coverage Diff                        @@
##             release-6.5-20230425-v6.5.2     #46173   +/-   ##
================================================================
  Coverage                               ?   73.4097%           
================================================================
  Files                                  ?       1079           
  Lines                                  ?     345991           
  Branches                               ?          0           
================================================================
  Hits                                   ?     253991           
  Misses                                 ?      75576           
  Partials                               ?      16424

ti-chi-bot · 2023-08-17T07:22:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, tangenta, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tangenta,you06]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-08-17T07:22:53Z

[LGTM Timeline notifier]

Timeline:

2023-08-17 03:21:28.187108426 +0000 UTC m=+774052.736124413: ☑️ agreed by tangenta.
2023-08-17 07:22:52.741402995 +0000 UTC m=+788537.290418982: ☑️ agreed by you06.

ddl, session: using table ID instead of partition ID when calling Spl…

1d42fd1

…itRegions

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 17, 2023

tangenta approved these changes Aug 17, 2023

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 17, 2023

crazycs520 approved these changes Aug 17, 2023

View reviewed changes

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 17, 2023

zimulala changed the title ~~ddl, session: using table ID instead of partition ID when calling SplitRegions~~ ddl, session: using table ID instead of partition ID when calling SplitRegions | tidb-test=pr/2145 Aug 17, 2023

you06 approved these changes Aug 17, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 17, 2023

ti-chi-bot bot merged commit 9354ebb into pingcap:release-6.5-20230425-v6.5.2 Aug 17, 2023
3 checks passed

zimulala deleted the zimuxia/groupid-v6.5.2 branch August 17, 2023 07:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl, session: using table ID instead of partition ID when calling SplitRegions | tidb-test=pr/2145 #46173

ddl, session: using table ID instead of partition ID when calling SplitRegions | tidb-test=pr/2145 #46173

zimulala commented Aug 17, 2023 •

edited

Loading

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

ti-chi-bot bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

codecov bot commented Aug 17, 2023

ti-chi-bot bot commented Aug 17, 2023

ti-chi-bot bot commented Aug 17, 2023

	for _, def := range parts {
	regionIDs = append(regionIDs, SplitRecordRegion(ctxWithTimeout, store, def.ID, scatter))
	}

	func SplitRecordRegion(ctx context.Context, store kv.SplittableStore, tableID int64, scatter bool) uint64 {
	tableStartKey := tablecodec.GenTablePrefix(tableID)
	regionIDs, err := store.SplitRegions(ctx, [][]byte{tableStartKey}, scatter, &tableID)

ddl, session: using table ID instead of partition ID when calling SplitRegions | tidb-test=pr/2145 #46173

ddl, session: using table ID instead of partition ID when calling SplitRegions | tidb-test=pr/2145 #46173

Conversation

zimulala commented Aug 17, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

ti-chi-bot bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

zimulala commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

codecov bot commented Aug 17, 2023

Codecov Report

ti-chi-bot bot commented Aug 17, 2023

ti-chi-bot bot commented Aug 17, 2023

[LGTM Timeline notifier]

zimulala commented Aug 17, 2023 •

edited

Loading