-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: standardize some terminologies in binding pkg #48957
Conversation
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48957 +/- ##
================================================
+ Coverage 70.9941% 72.6419% +1.6478%
================================================
Files 1368 1389 +21
Lines 404987 410950 +5963
================================================
+ Hits 287517 298522 +11005
+ Misses 97448 93581 -3867
+ Partials 20022 18847 -1175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What problem does this PR solve?
Issue Number: ref #48875
Problem Summary: planner: standardize some terminologies in binding pkg
What changed and how does it work?
NO LOGICAL CHANGE, just refactor:
binding
andbindRecord
tobinding
;session
andglobal
key word to each relevant function name;Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.