Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: standardize some terminologies in binding pkg #48957

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 28, 2023

What problem does this PR solve?

Issue Number: ref #48875

Problem Summary: planner: standardize some terminologies in binding pkg

What changed and how does it work?

NO LOGICAL CHANGE, just refactor:

  1. standardize binding and bindRecord to binding;
  2. add session and global key word to each relevant function name;

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 28, 2023
Copy link

tiprow bot commented Nov 28, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2023
Copy link

ti-chi-bot bot commented Nov 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-28 07:15:11.433586557 +0000 UTC m=+906940.098812753: ☑️ agreed by hawkingrei.
  • 2023-11-28 07:16:47.951250753 +0000 UTC m=+907036.616476948: ☑️ agreed by AilinKid.

@hawkingrei
Copy link
Member

/retest

Copy link

ti-chi-bot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #48957 (8fa0226) into master (c741119) will increase coverage by 1.6478%.
The diff coverage is 59.8039%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48957        +/-   ##
================================================
+ Coverage   70.9941%   72.6419%   +1.6478%     
================================================
  Files          1368       1389        +21     
  Lines        404987     410950      +5963     
================================================
+ Hits         287517     298522     +11005     
+ Misses        97448      93581      -3867     
+ Partials      20022      18847      -1175     
Flag Coverage Δ
integration 43.8423% <59.8039%> (?)
unit 70.9881% <ø> (-0.0060%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8110% <ø> (-4.2698%) ⬇️

@ti-chi-bot ti-chi-bot bot merged commit 46d4231 into pingcap:master Nov 28, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved epic/sql-plan-management lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants