-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: support universal binding create statements #49361
Conversation
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49361 +/- ##
================================================
+ Coverage 71.0491% 71.8890% +0.8398%
================================================
Files 1368 1411 +43
Lines 401712 414187 +12475
================================================
+ Hits 285413 297755 +12342
- Misses 96443 97629 +1186
+ Partials 19856 18803 -1053
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, easonn7, hawkingrei, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #48875
Problem Summary: planner: support universal binding create statements
What changed and how does it work?
Support the new syntax to create universal bindings:
CREATE [ GLOBAL | SESSION ] UNIVERSAL BINDING for BindableStmt USING BindableStmt;
CREATE [ GLOBAL | SESSION ] UNIVERSAL BINDING FROM HISTORY USING PLAN DIGEST '<plan_digest>';
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.