Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add more test cases for universal bindings #49544

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Dec 18, 2023

What problem does this PR solve?

Issue Number: ref #48875

Problem Summary: planner: add more test cases for universal bindings

What changed and how does it work?

add more test cases for universal bindings

NO LOGICAL CHANGE, JUST TEST.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 18, 2023
Copy link

tiprow bot commented Dec 18, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #49544 (8b73ca9) into master (3a7bd53) will increase coverage by 0.5574%.
Report is 1 commits behind head on master.
The diff coverage is 68.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49544        +/-   ##
================================================
+ Coverage   71.0009%   71.5583%   +0.5574%     
================================================
  Files          1368       1418        +50     
  Lines        399478     415250     +15772     
================================================
+ Hits         283633     297146     +13513     
- Misses        96044      99301      +3257     
+ Partials      19801      18803       -998     
Flag Coverage Δ
integration 43.6598% <68.0000%> (?)
unit 71.0008% <ø> (-0.0001%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.7771% <ø> (-5.1177%) ⬇️

Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [elsa0520,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2023
Copy link

ti-chi-bot bot commented Dec 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-18 06:01:37.876130828 +0000 UTC m=+854388.913357744: ☑️ agreed by hawkingrei.
  • 2023-12-18 06:11:16.135638511 +0000 UTC m=+854967.172865439: ☑️ agreed by elsa0520.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6645e24 into pingcap:master Dec 18, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants