Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: refactor limit hint #50730

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 25, 2024

What problem does this PR solve?

Issue Number: ref #48875

Problem Summary:

What changed and how does it work?

ONLY REFACTOR, NO LOGICAL CHANGE

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Merging #50730 (0df1b73) into master (f94e331) will increase coverage by 4.1685%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50730        +/-   ##
================================================
+ Coverage   70.3658%   74.5343%   +4.1685%     
================================================
  Files          1456       1458         +2     
  Lines        420835     421003       +168     
================================================
+ Hits         296124     313792     +17668     
+ Misses       104365      87451     -16914     
+ Partials      20346      19760       -586     
Flag Coverage Δ
integration 49.0610% <100.0000%> (?)
unit 70.2711% <100.0000%> (-0.0770%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.5356% <ø> (+5.9552%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 25, 2024
Copy link

ti-chi-bot bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 25, 2024
Copy link

ti-chi-bot bot commented Jan 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-25 11:28:46.285439362 +0000 UTC m=+1046567.849737063: ☑️ agreed by AilinKid.
  • 2024-01-25 11:32:47.902297089 +0000 UTC m=+1046809.466594794: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit 035df1a into pingcap:master Jan 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants