Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: rename base plan implemention's pkg from base to baseImpl #52659

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Apr 17, 2024

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 17, 2024
Copy link

tiprow bot commented Apr 17, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

.
Signed-off-by: AilinKid <314806019@qq.com>
.
Signed-off-by: AilinKid <314806019@qq.com>
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Merging #52659 (623e497) into master (1b3700c) will increase coverage by 1.5417%.
Report is 2 commits behind head on master.
The diff coverage is 94.2029%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52659        +/-   ##
================================================
+ Coverage   72.3518%   73.8936%   +1.5417%     
================================================
  Files          1471       1472         +1     
  Lines        427132     427176        +44     
================================================
+ Hits         309038     315656      +6618     
+ Misses        98838      91657      -7181     
- Partials      19256      19863       +607     
Flag Coverage Δ
integration 28.4056% <60.3864%> (?)
unit 71.1784% <94.2029%> (-0.0640%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.7359% <ø> (+8.6492%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 17, 2024
Copy link

ti-chi-bot bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: time-and-fate, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 17, 2024
Copy link

ti-chi-bot bot commented Apr 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-17 06:57:12.398101647 +0000 UTC m=+407651.509148093: ☑️ agreed by zimulala.
  • 2024-04-17 07:10:45.786342479 +0000 UTC m=+408464.897388925: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot merged commit ecb8a9e into pingcap:master Apr 17, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants