Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: refactor a few code of plan cache #54075

Merged
merged 10 commits into from
Jun 18, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 18, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: refactor a few code of plan cache

What changed and how does it work?

  1. unify the types of plan cache key/val/opts to use string/any/any;
  2. remove the unnecessary structure planCacheKey;
  3. move PlanCacheOpts into planner pacakge;
before:
  187170              6278 ns/op

after:
  191814              6223 ns/op

No regression

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 18, 2024
Copy link

tiprow bot commented Jun 18, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 90.76923% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.7451%. Comparing base (8f56847) to head (a1353da).
Report is 2 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54075         +/-   ##
=================================================
- Coverage   72.6029%   55.7451%   -16.8579%     
=================================================
  Files          1516       1636        +120     
  Lines        434689     605366     +170677     
=================================================
+ Hits         315597     337462      +21865     
- Misses        99623     244741     +145118     
- Partials      19469      23163       +3694     
Flag Coverage Δ
integration 36.4575% <87.6923%> (?)
unit 71.5159% <90.7692%> (-0.0777%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 50.5444% <ø> (+8.2429%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 18, 2024
Copy link

ti-chi-bot bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 18, 2024
Copy link

ti-chi-bot bot commented Jun 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-18 05:49:27.393161759 +0000 UTC m=+93893.878650592: ☑️ agreed by hawkingrei.
  • 2024-06-18 06:25:34.694679093 +0000 UTC m=+96061.180167926: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 00eafc0 into pingcap:master Jun 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants