Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/ut.go: add concurrent when listing pkgs #54306

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Jun 28, 2024

What problem does this PR solve?

Issue Number: Ref #30822

Problem Summary:

What changed and how does it work?

We can list pkg concurrently to accelerate build

check result

go clean -testcache
make gotest_in_verify_ci

before

building task finish, parallelism=144, count=5297, takes=2m5.029385545s

after

building task finish, parallelism=144, count=5297, takes=1m16.911219387s

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2024
@HuSharp
Copy link
Contributor Author

HuSharp commented Jun 28, 2024

cc @tiancaiamao @bb7133

Copy link

tiprow bot commented Jun 28, 2024

Hi @HuSharp. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.6628%. Comparing base (00eafc0) to head (9432360).
Report is 141 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54306         +/-   ##
=================================================
- Coverage   74.8294%   56.6628%   -18.1667%     
=================================================
  Files          1516       1644        +128     
  Lines        360862     622740     +261878     
=================================================
+ Hits         270031     352862      +82831     
- Misses        71259     246487     +175228     
- Partials      19572      23391       +3819     
Flag Coverage Δ
integration 37.0683% <ø> (?)
unit 71.8094% <ø> (-1.9127%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 52.2504% <ø> (+4.2638%) ⬆️

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@hawkingrei hawkingrei requested review from hawkingrei and tiancaiamao and removed request for hawkingrei June 30, 2024 03:35
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2024
Copy link

ti-chi-bot bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2024
Copy link

ti-chi-bot bot commented Jul 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-03 03:09:27.579704407 +0000 UTC m=+1380294.065193241: ☑️ agreed by zimulala.
  • 2024-07-03 16:52:32.642615581 +0000 UTC m=+1429679.128104413: ☑️ agreed by hawkingrei.

Copy link

tiprow bot commented Jul 3, 2024

@HuSharp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 9432360 link true /test fast_test_tiprow
tidb_parser_test 9432360 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 634ac69 into pingcap:master Jul 3, 2024
21 of 23 checks passed
@HuSharp HuSharp deleted the make_listpkg_concurrent branch July 3, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants