Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: use code-gen to generate CloneForPlanCache method for some operators #54957

Merged
merged 2 commits into from
Jul 26, 2024
Merged

planner: use code-gen to generate CloneForPlanCache method for some operators #54957

merged 2 commits into from
Jul 26, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 26, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: use code-gen to generate CloneForPlanCache method for some operators

What changed and how does it work?

planner: use code-gen to generate CloneForPlanCache method for some operators

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 26, 2024
@tiprow tiprow
Copy link

tiprow bot commented Jul 26, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 26, 2024
AilinKid
AilinKid reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pkg/planner/core/physical_plans.go Outdated
@@ -430,12 +430,12 @@ func (p *PushedDownLimit) MemoryUsage() (sum int64) {
type PhysicalIndexLookUpReader struct {
physicalSchemaProducer

indexPlan base.PhysicalPlan
tablePlan base.PhysicalPlan
Copy link
Contributor

@AilinKid AilinKid Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better export for later pkg move

pkg/planner/core/plan_clone_generated.go
cloned.tablePlan = tablePlan.(base.PhysicalPlan)
cloned.TablePlans = flattenPushDownPlan(cloned.tablePlan)
cloned.PlanPartInfo = op.PlanPartInfo.Clone()
if op.TableScanAndPartitionInfos != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if TableScanAndPartitionInfos != nil, refuse clone?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES, this field is only for MPP, but MPP plan is not supported by Plan Cache.

@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.96774% with 98 lines in your changes missing coverage. Please review.

Project coverage is 73.9923%. Comparing base (2ee8c99) to head (e94e4d1).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #54957        +/-   ##
================================================
+ Coverage   72.7724%   73.9923%   +1.2199%     
================================================
  Files          1559       1560         +1     
  Lines        438446     440521      +2075     
================================================
+ Hits         319068     325952      +6884     
+ Misses        99720      94613      -5107     
- Partials      19658      19956       +298
Flag Coverage Δ
integration 47.9277% <0.0000%> (?)
unit 71.6236% <20.9677%> (-0.1417%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 46.3853% <ø> (+0.4810%) ⬆️

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-26 08:50:07.713280338 +0000 UTC m=+1207829.704221808: ☑️ agreed by hawkingrei.
  • 2024-07-26 09:35:46.925901044 +0000 UTC m=+1210568.916842513: ☑️ agreed by AilinKid.

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 26, 2024

/test check-dev2

@tiprow tiprow
Copy link

tiprow bot commented Jul 26, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 97c2428 into pingcap:master Jul 26, 2024
23 checks passed
morgo added a commit to morgo/tidb that referenced this pull request Jul 28, 2024
@morgo
Merge remote-tracking branch 'upstream/master' into add-default-literal
4424521 
* upstream/master: (93 commits)
  disjoinset: add generic impl (pingcap#54917)
  planner: derive index filters for mv index paths (pingcap#54877)
  br: cli refactor backup error handling logic (pingcap#54697)
  expression: fix infinity loop in `timestampadd` (pingcap#54916)
  planner: import more expand test. (pingcap#54962)
  planner: use code-gen to generate CloneForPlanCache method for some operators (pingcap#54957)
  test: fix flaky test TestFailSchemaSyncer (pingcap#54958)
  planner: move logical show into logicalop pkg. (pingcap#54928)
  privilege: Remove TestAbnormalMySQLTable (pingcap#54925)
  resource_control: support unlimited keyword when setting the resource group (pingcap#54704)
  ddl: fix a data race on localRowCntListener Written() (pingcap#54484)
  lightning: fix SET SESSION on connection pool (pingcap#54927)
  planner: move logical mem-table to logicalop pkg. (pingcap#54903)
  table: Add `CachedTableSupport` and `TemporaryTableSupport` for `MutateContext` (pingcap#54900)
  executor: fix index_hash_join hang when context canceled (pingcap#54855)
  statistics: add metrics for unneeded analyze table (pingcap#54822)
  *: refine pipelined dml benchmarks (pingcap#54844)
  ddl: assign table IDs for jobs submitted to queue (pingcap#54880)
  *: avoid using Tables field of model.DBInfo, use API instead (pingcap#52302)
  planner: remove useless check (pingcap#54907)
  ...
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 1, 2024
@qw4990 @hawkingrei
planner: use code-gen to generate CloneForPlanCache method for some o…
8c0d393 
…perators (pingcap#54957)

ref pingcap#54057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qw4990 @hawkingrei @AilinKid