tools/ut.go: replace path with filepath #55122
Conversation
Signed-off-by: husharp <jinhao.hu@pingcap.com>
ti-chi-bot
bot
added
release-note-none
|
Hi @HuSharp. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Defined2014 @tangenta PTAL, thx! |
tools/check/ut.go
Outdated
| @@ -902,7 +901,7 @@ func generateBuildCache() error { | |||
| cmd := exec.Command("go", "test", "-tags=intest", "-exec=true", "-vet=off") | |||
| goCompileWithoutLink := fmt.Sprintf("-toolexec=%s/tools/check/go-compile-without-link.sh", workDir) | |||
| cmd.Args = append(cmd.Args, goCompileWithoutLink) | |||
| cmd.Dir = path.Join(workDir, "cmd/tidb-server") | |||
| cmd.Dir = filepath.Join(workDir, "cmd/tidb-server") | |||
There was a problem hiding this comment.
If we consider different operating systems, dose cmd/tidb-server also need to be changed?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55122 +/- ##
================================================
+ Coverage 74.7109% 75.0517% +0.3408%
================================================
Files 1563 1572 +9
Lines 364517 454986 +90469
================================================
+ Hits 272334 341475 +69141
- Misses 72402 92704 +20302
- Partials 19781 20807 +1026
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: husharp <ihusharp@gmail.com>
ti-chi-bot
bot
added
size/M
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Signed-off-by: husharp <ihusharp@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
@HuSharp: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
filepath.Joinis platform dependent and joins paths based on the operating system's path separator (e.g.,\on Windows and/on Unix).path.Joinis platform-independent and always uses/as the path separator.Issue Number: Ref #30822
Problem Summary:
What changed and how does it work?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.