Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: support using "KiB/MiB/GiB" to set isntance_plan_cache_target/max_mem_size #55316

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 9, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: support using "KiB/MiB/GiB" to set isntance_plan_cache_target/max_mem_size

What changed and how does it work?

planner: support using "KiB/MiB/GiB" to set isntance_plan_cache_target/max_mem_size to improve user experience

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2024
Copy link

tiprow bot commented Aug 9, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 9, 2024
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 9, 2024

/test check-dev2

Copy link

tiprow bot commented Aug 9, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 9, 2024
Copy link

ti-chi-bot bot commented Aug 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-09 02:50:53.464209814 +0000 UTC m=+579583.331308902: ☑️ agreed by hawkingrei.
  • 2024-08-09 03:22:59.322514592 +0000 UTC m=+581509.189613680: ☑️ agreed by AilinKid.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.1466%. Comparing base (cf2c703) to head (269532a).
Report is 1 commits behind head on master.

Current head 269532a differs from pull request most recent head beb04fc

Please upload reports for the commit beb04fc to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55316        +/-   ##
================================================
+ Coverage   72.9389%   74.1466%   +1.2077%     
================================================
  Files          1570       1570                
  Lines        439546     439552         +6     
================================================
+ Hits         320600     325913      +5313     
+ Misses        99279      93424      -5855     
- Partials      19667      20215       +548     
Flag Coverage Δ
integration 26.2198% <33.3333%> (?)
unit 71.7887% <50.0000%> (-0.1902%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.4486% <ø> (+6.5731%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2024
@qw4990 qw4990 changed the title planner: support using "KB/MB/GB" to set isntance_plan_cache_target/max_mem_size planner: support using "KiB/MiB/GiB" to set isntance_plan_cache_target/max_mem_size Aug 9, 2024
@easonn7
Copy link

easonn7 commented Aug 9, 2024

/approve

Copy link

ti-chi-bot bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, easonn7, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2a731e6 into pingcap:master Aug 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants