Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: introduce hashEqual interface for datum. #55727

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

.
Signed-off-by: arenatlx <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2024
Copy link

tiprow bot commented Aug 28, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

.
Signed-off-by: arenatlx <314806019@qq.com>
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.6436%. Comparing base (4f85a35) to head (78dc3a7).
Report is 11 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55727        +/-   ##
================================================
+ Coverage   72.8618%   74.6436%   +1.7818%     
================================================
  Files          1582       1582                
  Lines        442708     443983      +1275     
================================================
+ Hits         322565     331405      +8840     
+ Misses       100322      92268      -8054     
- Partials      19821      20310       +489     
Flag Coverage Δ
integration 48.9649% <4.5454%> (?)
unit 71.8731% <72.7272%> (-0.1101%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.0825% <ø> (+6.6446%) ⬆️

.
Signed-off-by: arenatlx <314806019@qq.com>
.
Signed-off-by: arenatlx <314806019@qq.com>
@@ -1586,6 +1587,20 @@ func ConvertByCollationStr(str string, tp *types.FieldType) string {
return string(hack.String(collator.Key(str)))
}

// Hash64 is for datum hash64 calculation.
func Hash64(h base.Hasher, d *types.Datum) {
// let h.cache to receive datum hash value, which is potentially expendable.
Copy link
Contributor Author

@AilinKid AilinKid Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passing hasher into every encoding logic of datum field means we need to mutate many codec functions, which is dirty.

here we just choose to let hasher ingest datum.HashCode() bytes to make it. See the Line 1606

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 29, 2024
.
Signed-off-by: arenatlx <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added the approved label Aug 29, 2024
.
Signed-off-by: arenatlx <314806019@qq.com>
Copy link

ti-chi-bot bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 29, 2024
Copy link

ti-chi-bot bot commented Aug 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-29 06:34:09.898128347 +0000 UTC m=+1024845.032578468: ☑️ agreed by winoros.
  • 2024-08-29 08:50:43.025785709 +0000 UTC m=+1033038.160235830: ☑️ agreed by hawkingrei.

Copy link

tiprow bot commented Aug 29, 2024

@AilinKid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 78dc3a7 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit f5fff6c into pingcap:master Aug 29, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants