-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charset,collation: implement GB18030
and 2 collations | tidb-test=pr/2087
#55792
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55792 +/- ##
=================================================
- Coverage 73.0085% 59.7897% -13.2188%
=================================================
Files 1584 1813 +229
Lines 443036 688212 +245176
=================================================
+ Hits 323454 411480 +88026
- Misses 99870 252061 +152191
- Partials 19712 24671 +4959
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GB18030
and 2 collationsGB18030
and 2 collations | tidb-test=pr/2087
Waiting for tikv/tikv#17467 to pass check_dev_2 |
GB18030
and 2 collations | tidb-test=pr/2087GB18030
and 2 collations | tidb-test=pr/2087
GB18030
and 2 collations | tidb-test=pr/2087GB18030
and 2 collations | tidb-test=pr/2087
/retest |
) | ||
|
||
//go:embed gb18030_weight.data | ||
var gb18030WeightData []byte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did we get this *.data
file? Is it generated by a program or downloaded from some places?
[LGTM Timeline notifier]Timeline:
|
/retest |
/hold |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Benjamin2037, wjhuang2016 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cc fzzf678 |
/retest |
@CbcWestwolf: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@CbcWestwolf: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #55791
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.