codec: support mysql Duration codec #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +38,7 @@ const ( | |||
| formatFloatFlag = 'f' | |||
| formatStringFlag = 's' | |||
| formatBytesFlag = 'b' | |||
| formatDuration = 't' | |||
There was a problem hiding this comment.
formatDuration -> formatDurationFlag?
| b, r, err = DecodeInt(b) | ||
| if err == nil { | ||
| // use max fsp, let outer to do round manually. | ||
| v[i] = mysql.Duration{Duration: time.Duration(r), Fsp: mysql.MaxFsp} |
There was a problem hiding this comment.
How about encode fsp and decode it here?
There was a problem hiding this comment.
maybe no need here, but I am not sure.
As you know, we handle encode any fsp in table value codec or time marshal too, just let outer do the convert manually.
|
LGTM |
siddontang
added a commit
that referenced
this pull request
Sep 8, 2015
codec: support mysql Duration codec
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
Signed-off-by: Neil Shen <overvenus@gmail.com>
Defined2014
pushed a commit
to Defined2014/tidb
that referenced
this pull request
Apr 13, 2022
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
Oct 31, 2022
* disable remove scheduler and other pd related modifications when keyspace is set for BR Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
nolouch
pushed a commit
to tidblabs/tidb
that referenced
this pull request
Jan 6, 2023
* BR adaption for keyspace feature (pingcap#38) Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Co-authored-by: ystaticy <y_static_y@sina.com> Co-authored-by: disksing <i@disksing.com> * build br image (pingcap#62) * build br image Signed-off-by: disksing <i@disksing.com> * BR: Serverless Compatible BR (pingcap#64) * disable remove scheduler and other pd related modifications when keyspace is set for BR Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * make tidb br forward compatible (pingcap#84) * make tidb br forward compatible Signed-off-by: iosmanthus <myosmanthustree@gmail.com> * fix bug,when tables>0 and file=0 Signed-off-by: ystaticy <y_static_y@sina.com> * go mod tidy Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Signed-off-by: ystaticy <y_static_y@sina.com> Co-authored-by: ystaticy <y_static_y@sina.com> * Cse BR restore only download on leader (pingcap#120) * cse br restore,only download in region leader * support config Signed-off-by: ystaticy <y_static_y@sina.com> * cse br restore,only download in region leader Signed-off-by: ystaticy <y_static_y@sina.com> * cse br restore,only download in region leader Signed-off-by: ystaticy <y_static_y@sina.com> * fix logs Signed-off-by: ystaticy <y_static_y@sina.com> * fix logs Signed-off-by: ystaticy <y_static_y@sina.com> * fix logs Signed-off-by: ystaticy <y_static_y@sina.com> * remove unused code Signed-off-by: ystaticy <y_static_y@sina.com> * fix imports Signed-off-by: ystaticy <y_static_y@sina.com> * fix comments Signed-off-by: ystaticy <y_static_y@sina.com> * fix config of leaderdownload Signed-off-by: ystaticy <y_static_y@sina.com> * fix config of leaderdownload Signed-off-by: ystaticy <y_static_y@sina.com> * if met not leader error.return error immediately. Signed-off-by: ystaticy <y_static_y@sina.com> Signed-off-by: ystaticy <y_static_y@sina.com> * support skip split option for small dataset (pingcap#122) * support skip split option for small dataset Signed-off-by: iosmanthus <myosmanthustree@gmail.com> * disable SplitTable only when skip split Signed-off-by: iosmanthus <myosmanthustree@gmail.com> * rename api version of FileImporter Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Signed-off-by: disksing <i@disksing.com> Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> Signed-off-by: ystaticy <y_static_y@sina.com> Co-authored-by: ystaticy <y_static_y@sina.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
mittalrishabh
pushed a commit
to mittalrishabh/tidb
that referenced
this pull request
May 6, 2024
…ingcap#64) close pingcap#52049 Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.