stats: fix auto analyze trigger condition #7550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
coocood
added
type/bugfix
|
/run-all-tests |
winoros
approved these changes
Aug 30, 2018
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Aug 30, 2018
zz-jason
pushed a commit
that referenced
this pull request
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The auto analyze work keeps on analyzing the same table even if there is no data change.
What is changed and how it works?
It is caused by the wrong auto analyze trigger condition. We cannot use the histogram bucket count to decide if the column is analyzed or not, because we may not load the histogram from storage. But we can use the count of rows at the time of analyzing to check it.
Check List
Tests
Code changes
Side effects
Related changes
PTAL @coocood @zz-jason @winoros