expression: fix cast unsigned integer to decimal #7792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
winoros
reviewed
Sep 27, 2018
| f = BuildCastFunction(ctx, &Constant{Value: types.NewUintDatum(18446744073709551615), RetType: rt}, ft) | ||
| res, err = f.Eval(chunk.Row{}) | ||
| c.Assert(err, IsNil) | ||
| u, err := res.GetMysqlDecimal().ToUint() |
There was a problem hiding this comment.
Here it's more likely checking cast(cast(arg as decimal) as unsigned).
Maybe ToString is better?
There was a problem hiding this comment.
It's not like cast(cast(arg as decimal) as unsigned) , because when cast(arg as decimal) returns signed， res.GetMysqlDecimal().ToUint() will return range exceed error.
winoros
added
status/LGT1
zz-jason
changed the title
|
/run-all-tests |
zz-jason
added
status/LGT2
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… integer range
What problem does this PR solve?
fix #7778
What is changed and how it works?
in evalDecimal function, it not only check the cast type unsigned flag, but also check the unsigned flag of arg
Check List
Tests