Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx: make tidb_max_chunk_size as a global variable (#6585) #8333

Merged
merged 2 commits into from
Nov 16, 2018

Conversation

zz-jason
Copy link
Member

cherry pick #6585 to release-2.0

@zz-jason
Copy link
Member Author

@eurekaka @XuHuaiyu @jackysp PTAL

@zz-jason
Copy link
Member Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason zz-jason added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Nov 15, 2018
@@ -1650,6 +1650,10 @@ func (s *testSchemaSuite) TestTableReaderChunk(c *C) {
s.cluster.SplitTable(s.mvccStore, tbl.Meta().ID, 10)

tk.Se.GetSessionVars().DistSQLScanConcurrency = 1
tk.MustExec("set tidb_max_chunk_size = 2")
defer func() {
tk.MustExec(fmt.Sprintf("set tidb_max_chunk_size = %d", variable.DefMaxChunkSize))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just set tidb_max_chunk_size=default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Nov 16, 2018
@zz-jason zz-jason merged commit 34d9050 into pingcap:release-2.0 Nov 16, 2018
@zz-jason zz-jason deleted the cherrypick/global_chunk_size branch November 16, 2018 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants