Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: add check when create table with foreign key. (#7885) #8410

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Nov 22, 2018

What problem does this PR solve?

cherry-pick from #7885.


This change is Reviewable

* ddl: add check when create table with foreign key
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

@crazycs520
Copy link
Contributor Author

@zimulala @winkyao @ciscoxll PTAL

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

@crazycs520 crazycs520 changed the title ddl: check foreign key ddl: check foreign key when create table. Nov 23, 2018
@zz-jason zz-jason changed the title ddl: check foreign key when create table. ddl: add check when create table with foreign key. (#7885) Nov 23, 2018
@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2018
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit 3f03b30 into pingcap:release-2.0 Nov 23, 2018
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants