ddl: update parser to make TiDB treat charset and collate case insensitive #8577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winkyao
changed the title
|
@tiancaiamao PTAL |
zimulala
reviewed
Dec 5, 2018
There was a problem hiding this comment.
Release Version: v2.0.9-20-ged6e8ff
Git Commit Hash: ed6e8ff6b3df1eb64b1050e008d922b981a75329
tidb> create table test(id int) ENGINE=InnoDB DEFAULT CHARSET=UTF8 COLLATE=UTF8_BIN;
ERROR 1115 (42000): Unknown character set: 'UTF8'
tidb> create table test(id int) ENGINE=InnoDB DEFAULT CHARSET=UTF8 COLLATE=utf8_bin;
ERROR 1115 (42000): Unknown character set: 'UTF8'
Release Version: v2.1.0-2-gb2382fb
Git Commit Hash: b2382fbe6c34d2ce200018ff765b1acb05cc7f6b
tidb> create table test(id int) ENGINE=InnoDB DEFAULT CHARSET=UTF8 COLLATE=UTF8_BIN;
ERROR 1115 (42000): Unknown character set: 'UTF8'
tidb> create table test(id int) ENGINE=InnoDB DEFAULT CHARSET=UTF8 COLLATE=utf8_bin;
Query OK, 0 rows affected (0.11 sec)
It seems can't pass these tests in v2.0 and v2.1. We need to fix these.
|
@zimulala release-2.1 is not using master branch parser |
|
/run-all-tests |
|
@zimulala The changes in parser need to cherry-pick to 2.1 branches later. Never mind. |
|
LGTM |
|
/run-all-tests |
tiancaiamao
approved these changes
Dec 6, 2018
zz-jason
added
status/LGT2
winkyao
added a commit
that referenced
this pull request
Dec 12, 2018
iamzhoug37
pushed a commit
to iamzhoug37/tidb
that referenced
this pull request
Dec 13, 2018
winkyao
added a commit
that referenced
this pull request
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #8304
What is changed and how it works?
Actually, pingcap/parser#66 fix this problem, we just add some test cases and update the go.mod to the corresponding parser will work.
Check List
Tests
Related changes
This change is