planner: support building data source from View #8757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
AndrewDi
force-pushed
the
view/implement_select_view
branch
from
81179a1
to
49c1183
Compare
|
/rebuild |
XuHuaiyu
reviewed
Dec 20, 2018
|
Add a test case for changing column order of the underlying table. create table t(a int, b int);
create view v as select * from t;
alter table t drop column a;
alter table t add column a int after b;
select * from v; |
XuHuaiyu
added
contribution
|
@XuHuaiyu PTAL |
XuHuaiyu
reviewed
Dec 20, 2018
planner/core/logical_plan_builder.go
Outdated
| if col == nil { | ||
| return nil, ErrViewInvalid.GenWithStackByArgs(dbName.L, tableInfo.Name.L) | ||
| } | ||
| col.ColName = tableInfo.Cols()[i].Name |
There was a problem hiding this comment.
line2018 and line2019 is useless.
planner/core/logical_plan_builder.go
Outdated
| } | ||
| projUponView := LogicalProjection{Exprs: expression.Column2Exprs(viewCols)}.Init(b.ctx) | ||
| projUponView.SetChildren(selectLogicalPlan.(LogicalPlan)) | ||
| projUponView.SetSchema(expression.NewSchema(viewCols...)) |
There was a problem hiding this comment.
We should build schema.Columns instead of using the selectLogicalPlan.Schema.Columns
&expression.Column{
UniqueID: b.ctx.GetSessionVars().AllocPlanColumnID(),
TblName: viewname,
OrigTblName: tableInfo.Cols[i].Name,
ColName: colName,
OrigColName: tableInfo.View.Cols[i].Name,
DBName: dbName,
RetType: expr.GetType(),
}There was a problem hiding this comment.
We should not use the column in the child schema as the parent schema
There was a problem hiding this comment.
Understand, PTAL again
XuHuaiyu
previously approved these changes
Dec 20, 2018
winoros
reviewed
Dec 21, 2018
AndrewDi
force-pushed
the
view/implement_select_view
branch
from
bf8d417
to
b60541c
Compare
AndrewDi
force-pushed
the
view/implement_select_view
branch
from
0a7c265
to
c855ba4
Compare
XuHuaiyu
reviewed
Dec 24, 2018
winoros
previously approved these changes
Dec 24, 2018
|
/run-all-tests |
|
/rebuild |
zz-jason
reviewed
Dec 25, 2018
planner/core/logical_plan_builder.go
Outdated
| @@ -1994,6 +1998,46 @@ func (b *PlanBuilder) buildDataSource(tn *ast.TableName) (LogicalPlan, error) { | |||
| return result, nil | |||
| } | |||
|
|
|||
| func (b *PlanBuilder) buildDataSourceFromView(dbName model.CIStr, tableInfo *model.TableInfo) (LogicalPlan, error) { | |||
| var ( | |||
There was a problem hiding this comment.
These variable declaration looks ugly. We can avoid this by using the := operator in golang.
|
/run-all-tests |
…wDi/tidb into view/implement_select_view
|
@zz-jason PTAL |
zz-jason
changed the title
yu34po
pushed a commit
to yu34po/tidb
that referenced
this pull request
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement basic select view feature
What is changed and how it works?
ref proposal Proposal: Implement View Feature
Check List
Tests
This change is