Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, executor: fix rename table compatibility (#8709) #8808

Merged
merged 2 commits into from
Dec 25, 2018
Merged

ddl, executor: fix rename table compatibility (#8709) #8808

merged 2 commits into from
Dec 25, 2018

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Dec 25, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

cherry pick #8709

This change is Reviewable

@zimulala
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zimulala
Copy link
Contributor Author

PTAL @ciscoxll @crazycs520 @winkyao

winkyao
winkyao reviewed Dec 25, 2018
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 25, 2018
@zimulala
Copy link
Contributor Author

PTAL @crazycs520 @ciscoxll

crazycs520
crazycs520 approved these changes Dec 25, 2018
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 25, 2018
@zimulala zimulala merged commit fae6021 into pingcap:release-2.1 Dec 25, 2018
@zimulala zimulala deleted the rename-table-2.1 branch December 25, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zimulala @winkyao @crazycs520