Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: adjust message about Charset&&Collation in 'show create table` for compatibility #9306

Merged
merged 5 commits into from
Feb 15, 2019
Merged

Conversation

xiekeyi98
Copy link
Contributor

What problem does this PR solve?

Cherry-pick from #9113

@xiekeyi98
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@xiekeyi98
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zimulala
Copy link
Contributor

Please fix the CI.

@xiekeyi98
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@xiekeyi98
Copy link
Contributor Author

/run-all-tests tidb-test=pr/736 tikv=release-2.1 pd=release-2.1

@xiekeyi98
Copy link
Contributor Author

/run-common-tests tidb-test=pr/736 tikv=release-2.1 pd=release-2.1

1 similar comment
@xiekeyi98
Copy link
Contributor Author

/run-common-tests tidb-test=pr/736 tikv=release-2.1 pd=release-2.1

@xiekeyi98
Copy link
Contributor Author

/run-all-tests tidb-test=pr/736 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2019
@zz-jason zz-jason merged commit 1aa05f8 into pingcap:release-2.1 Feb 15, 2019
@xiekeyi98 xiekeyi98 deleted the cherrypick#9113 branch February 15, 2019 09:42
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants