executor, plan: add executor to support GRANT ROLE
#9721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
parser pr: pingcap/parser#242 |
Codecov Report
@@ Coverage Diff @@
## master #9721 +/- ##
================================================
- Coverage 77.5494% 77.5426% -0.0068%
================================================
Files 404 404
Lines 81704 81706 +2
================================================
- Hits 63361 63357 -4
+ Misses 13649 13646 -3
- Partials 4694 4703 +9 |
|
LGTM |
|
Please resolve the conflicts. |
added 2 commits
March 25, 2019 10:58
|
/rebuild |
|
/run-all-tests |
alivxxx
reviewed
Mar 25, 2019
zz-jason
reviewed
Mar 25, 2019
zz-jason
reviewed
Mar 25, 2019
zz-jason
reviewed
Mar 25, 2019
added 2 commits
March 25, 2019 19:29
|
PTAL @zz-jason |
|
/run-all-tests |
|
/run-all-tests |
zz-jason
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add executor to support SQL like
GRANT roles TO users.What is changed and how it works?
Adding
executeGrantRoleforSimpleExecexecutor. Checking whether all roles and users exist before grant. When executingGRANT ROLE, executor will insert tuple intomysql.role_edgestable and flush privilege.Test case will be added later.
Check List
Tests
Code changes
Side effects