ddl: fix alter table share rowid bit problem #9868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winkyao
reviewed
Mar 25, 2019
|
Please merge pingcap/parser#252 first. |
winkyao
reviewed
Mar 28, 2019
winkyao
reviewed
Mar 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #9868 +/- ##
===============================================
- Coverage 78.1391% 78.121% -0.0182%
===============================================
Files 405 405
Lines 82005 82033 +28
===============================================
+ Hits 64078 64085 +7
- Misses 13231 13248 +17
- Partials 4696 4700 +4 |
zimulala
reviewed
Apr 8, 2019
Co-Authored-By: crazycs520 <crazycs520@gmail.com>
…to fix-share-bit
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
bb7133
reviewed
Apr 8, 2019
|
LGTM |
tiancaiamao
added
status/LGT2
zimulala
added
status/LGT3
|
/run-all-tests |
|
/run-all-tests |
|
/rebuild |
zimulala
approved these changes
Apr 9, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
May 13, 2019
zz-jason
pushed a commit
that referenced
this pull request
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
There is some problem in share rowid bits. Think about follow situation.
The current SHARD_ROW_ID_BITS = 6, then, after alter SHARD_ROW_ID_BITS = 4,
What is changed and how it works?
Add a
MaxShardRowIDBitsto tableInfo to record the max ShardRowIDBits has been used.Then use
MaxShardRowIDBitsto check autoID overflow.Then in upper situation, after SHARD_ROW_ID_BITS = 4, TiDB will also use 6 to check allocateAutoID overflow. then the duplicate ID cannot be insert , because the duplicated ID is overflow with MaxShardRowIDBits=6.
Related Parser PR: pingcap/parser#252, Pleaser merge parser first.
Check List
Tests
Code changes
Side effects
Related changes