Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: using ToHashKey to check equality of decimal when count(distinct) (#9901) #9931

Merged
merged 2 commits into from
Mar 28, 2019

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #9901

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

if err != nil || isNull {
return encodedBytes, isNull, errors.Trace(err)
break
}
encodedBytes = appendInt64(encodedBytes, buf, val)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
encodedBytes = appendInt64(encodedBytes, buf, val)
val, isNull, err = arg.EvalInt(sctx, row)
if err == nil && !isNull {
encodedBytes = appendInt64(encodedBytes, buf, val)
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok here.
I'll change this format in master.

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala merged commit 2033c23 into pingcap:release-2.1 Mar 28, 2019
@XuHuaiyu XuHuaiyu deleted the cherry-pick-2.1 branch April 22, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants