Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

push down Left/right to tiflash #2045

Merged
merged 10 commits into from
Jun 3, 2021
Merged

push down Left/right to tiflash #2045

merged 10 commits into from
Jun 3, 2021

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Jun 1, 2021

What problem does this PR solve?

Issue Number: close ##1943

Problem Summary: push down left/right to tiflash, but only accept constants for the second parameter.

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

Release note

  • push down Left/right to tiflash

@fzhedu fzhedu requested review from windtalker and leiysky June 1, 2021 10:13
@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 1, 2021

related pingcap/tidb#25018

windtalker
windtalker approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 1961
  • 2026

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 6bcde41 into pingcap:master Jun 3, 2021
@fzhedu fzhedu added the needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 label Jun 3, 2021
@ti-srebot ti-srebot mentioned this pull request Jun 3, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #2076

fzhedu added a commit that referenced this pull request Jun 18, 2021
@ti-srebot @fzhedu
push down Left/right to tiflash (#2045) (#2076)
39dbbfe 
* cherry pick #2045 to release-5.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update expr_push_down.test

* Update expr_push_down.test

Co-authored-by: Zhuhe Fang <fzhedu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiysky leiysky leiysky left review comments

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fzhedu @ti-srebot @windtalker @leiysky