Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function: Support push function year,day,datediff,datesub,castTimeAsString,concat_ws down to TiFlash. #2084

Merged
merged 15 commits into from
Jun 4, 2021

Conversation

LittleFall
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #1480

Problem Summary: Support push fucntion year,day,datediff,datesub,castTimeAsString down to TiFlash.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch: 5.0

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note.

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
@LittleFall
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@LittleFall
Copy link
Contributor Author

/label needs-cherry-pick-5.0

@ti-srebot ti-srebot added the needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 label Jun 4, 2021
@ti-srebot
Copy link
Collaborator

@LittleFall merge failed.

@LittleFall
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@LittleFall merge failed.

@LittleFall
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #2089

@LittleFall LittleFall deleted the enhance/functions branch June 4, 2021 10:03
LittleFall added a commit that referenced this pull request Jun 16, 2021
ti-srebot added a commit that referenced this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need support more function pushdown in TiFlash
3 participants