Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: hide --sort-dir in changefeed command. (deprecated warning exists) #1784

Merged
merged 4 commits into from
May 19, 2021
Merged

cmd: hide --sort-dir in changefeed command. (deprecated warning exists) #1784

merged 4 commits into from
May 19, 2021

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented May 17, 2021 •
edited
Loading

What problem does this PR solve?

Hide --sort-dir in changefeed command

What is changed and how it works?

  • Hide --sort-dir in changefeed command
  • Set SortDir to `json:"-"` in changefeed, so the changefeed query won't print any sort-dir which may confuse user. Note only set it to an ignore field is backward compatibility

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. labels May 17, 2021
@amyangfei amyangfei added this to the v5.0.2 milestone May 17, 2021
@ti-chi-bot ti-chi-bot requested a review from liuzix May 17, 2021 08:05
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2021
@amyangfei amyangfei removed the request for review from liuzix May 17, 2021 08:07
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/run-leak-tests

@IANTHEREAL
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • IANTHEREAL
  • leoppro

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2021 •
edited
Loading

Codecov Report

Merging #1784 (368d9b5) into master (58c6ca1) will increase coverage by 0.1206%.
The diff coverage is 16.6666%.

@@               Coverage Diff                @@
##             master      #1784        +/-   ##
================================================
+ Coverage   52.8749%   52.9955%   +0.1206%     
================================================
  Files           153        153                
  Lines         15896      15890         -6     
================================================
+ Hits           8405       8421        +16     
+ Misses         6582       6563        -19     
+ Partials        909        906         -3

@zier-one
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 368d9b5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2021
@purelind
Copy link
Collaborator

/run-integration-common-test

@amyangfei
Copy link
Contributor Author

/run-all-tests

lonng
lonng reviewed May 19, 2021
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lonng
Copy link
Contributor

lonng commented May 19, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 796c966 into pingcap:master May 19, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1794.

This was referenced May 19, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1795.

ti-chi-bot added a commit that referenced this pull request May 19, 2021
@ti-chi-bot
cmd: hide --sort-dir in changefeed command. (deprecated warning exist…
bccc2fe 
…s) (#1784) (#1794)
ti-chi-bot added a commit that referenced this pull request May 27, 2021
@ti-chi-bot
cmd: hide --sort-dir in changefeed command. (deprecated warning exist…
4eaf09d 
…s) (#1784) (#1795)
@3AceShowHand 3AceShowHand mentioned this pull request Jul 5, 2021
Merged
This was referenced Jul 7, 2021
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonng lonng lonng left review comments

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
7 participants
@amyangfei @IANTHEREAL @ti-chi-bot @codecov-commenter @zier-one @purelind @lonng