Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline: reduce tick message in-use objects #2226

Merged
merged 3 commits into from
Jul 7, 2021
Merged

pipeline: reduce tick message in-use objects #2226

merged 3 commits into from
Jul 7, 2021

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Reduce tick message in-use objects.

Cc: #2212

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@overvenus
pipeline: reduce tick message in-use objects
21cf846 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added component/replica-model Replication model component. subject/performance Denotes an issue or pull request is related to replication performance. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. labels Jul 6, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 6, 2021
amyangfei
amyangfei reviewed Jul 6, 2021
View reviewed changes
pkg/pipeline/message.go
@@ -64,11 +64,15 @@ func BarrierMessage(barrierTs model.Ts) *Message {
}
}

// TickMessage is called frequently,
// to ease GC pressure we return a global variable.
var tickMsg *Message = &Message{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment about this var is readonly

@overvenus
address comments
e991deb 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2021
@amyangfei
Copy link
Contributor

/run-all-tests

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e991deb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit 661e175 into pingcap:master Jul 7, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2231.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 7, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2232.

This was referenced Jul 7, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2233.

ti-chi-bot added a commit that referenced this pull request Jul 12, 2021
@ti-chi-bot
pipeline: reduce tick message in-use objects (#2226) (#2231)
2124c7f
ti-chi-bot added a commit that referenced this pull request Jul 16, 2021
@ti-chi-bot
pipeline: reduce tick message in-use objects (#2226) (#2232)
b56b860
ti-chi-bot added a commit that referenced this pull request Jul 17, 2021
@ti-chi-bot
pipeline: reduce tick message in-use objects (#2226) (#2233)
a389670
@overvenus overvenus mentioned this pull request Aug 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@liuzix liuzix liuzix approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees
No one assigned
Labels
component/replica-model Replication model component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. subject/performance Denotes an issue or pull request is related to replication performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @amyangfei @ti-chi-bot @liuzix