Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: use values to reduce GC pressure (#2474) #2497

Merged
merged 8 commits into from
Aug 12, 2021
Merged

*: use values to reduce GC pressure (#2474) #2497

merged 8 commits into from
Aug 12, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2474

What problem does this PR solve?

Use prefer using values for channel types to reduce GC pressure. Same as #2415

Left: master
Right: this patch

Max (master): ~80ms
Max (this patch): ~35ms
image
image
image
image

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note 

None

@overvenus @ti-chi-bot
workerpool: use task value to reduce GC pressure
61c94f7 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus @ti-chi-bot
kv/client: use regionEvent value to reduce GC pressure
244ba0e 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus @ti-chi-bot
kv, puller: use RegionFeedEvent value to reduce GC pressure
a8ddf43 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus @ti-chi-bot
workerpool: add benchmark
c6d8387 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus @ti-chi-bot
fix lints
97efb5d 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 11, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 11, 2021
Merged
@ti-chi-bot ti-chi-bot added release-blocker This issue blocks a release. Please solve it ASAP. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. subject/performance Denotes an issue or pull request is related to replication performance. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Aug 11, 2021
@amyangfei amyangfei added this to the v5.2.0 milestone Aug 11, 2021
@amyangfei amyangfei removed the require-LGT1 Indicates that the PR requires an LGTM. label Aug 11, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 11, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 97efb5d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-5.2@89aa3d9). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.2      #2497   +/-   ##
================================================
  Coverage               ?   55.8065%           
================================================
  Files                  ?        168           
  Lines                  ?      20494           
  Branches               ?          0           
================================================
  Hits                   ?      11437           
  Misses                 ?       7956           
  Partials               ?       1101

@nongfushanquan nongfushanquan added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 11, 2021
@lonng
Copy link
Contributor

lonng commented Aug 11, 2021

/merge

@overvenus
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

/run-integration-tests

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2021
@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 12, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 4481800

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit 89de355 into pingcap:release-5.2 Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@liuzix liuzix liuzix approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@overvenus overvenus

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-blocker This issue blocks a release. Please solve it ASAP. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. subject/performance Denotes an issue or pull request is related to replication performance. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-chi-bot @amyangfei @codecov-commenter @lonng @overvenus @Rustin170506 @liuzix @nongfushanquan