processor: fix processor doesn't fully exit after p.stop is called
#693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
===========================================
Coverage 31.6600% 31.6600%
===========================================
Files 90 90
Lines 9084 9084
===========================================
Hits 2876 2876
Misses 5972 5972
Partials 236 236 |
|
/run-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In some tests we find after changefeed is stopped via admin API, processor maybe not fully exit, and some kv client blocks at
stream.Recv.After some investigation we find processor doesn't cancel ddl puller when
p.stop()is called.What is changed and how it works?
Cancel ddl puller when in processor stop.
Check List
Tests
Release note