Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pulsar's sink. #751

Merged
merged 5 commits into from
Jul 15, 2020
Merged

support pulsar's sink. #751

merged 5 commits into from
Jul 15, 2020

Conversation

cocotyty
Copy link
Contributor

@cocotyty cocotyty commented Jul 15, 2020

What problem does this PR solve?

support pulsar's sink. #681

What is changed and how it works?

add pulsar client codes to implement mqProducer.Producer, just call pulsar client to send msgs.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Support pulsar sink(experimental)

@zier-one
Copy link
Contributor

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2020
@zier-one zier-one requested a review from amyangfei July 15, 2020 06:43
@zier-one zier-one added this to the v4.0.3 milestone Jul 15, 2020
@zier-one zier-one added the release-blocker This issue blocks a release. Please solve it ASAP. label Jul 15, 2020
@amyangfei amyangfei added the component/sink Sink component. label Jul 15, 2020
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2020
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@cocotyty merge failed.

@amyangfei
Copy link
Contributor

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests

@zier-one
Copy link
Contributor

/merge

2 similar comments
@zier-one
Copy link
Contributor

/merge

@zier-one
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@cocotyty merge failed.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@cocotyty merge failed.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@cocotyty merge failed.

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #751 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #751   +/-   ##
===========================================
  Coverage   33.8114%   33.8114%           
===========================================
  Files            92         92           
  Lines         10109      10109           
===========================================
  Hits           3418       3418           
  Misses         6361       6361           
  Partials        330        330           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/sink Sink component. release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants