fix: checks for undefined specifically instead of falsey values

pinojs · Jul 1, 2023 · ee1dc40 · ee1dc40
1 parent 425414b
commit ee1dc40
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -162,7 +162,7 @@ function prettyFactory (options) {
       line += ':'
     }
 
-    if (prettifiedMessage) {
+    if (prettifiedMessage !== undefined) {
       if (line.length > 0) {
         line = `${line} ${prettifiedMessage}`
       } else {

diff --git a/test/basic.test.js b/test/basic.test.js
@@ -133,7 +133,7 @@ test('basic prettifier tests', (t) => {
     }))
     log.info('baz')
   })
-  
+
   t.test('can print message key value when its a number', (t) => {
     t.plan(1)
     const pretty = prettyFactory()
@@ -149,7 +149,23 @@ test('basic prettifier tests', (t) => {
     }))
     log.info(42)
   })
-
+
+  t.test('can print message key value when its a Number(0)', (t) => {
+    t.plan(1)
+    const pretty = prettyFactory()
+    const log = pino({}, new Writable({
+      write (chunk, enc, cb) {
+        const formatted = pretty(chunk.toString())
+        t.equal(
+          formatted,
+          `[${formattedEpoch}] INFO (${pid}): 0\n`
+        )
+        cb()
+      }
+    }))
+    log.info(0)
+  })
+
   t.test('can print message key value when its a boolean', (t) => {
     t.plan(1)
     const pretty = prettyFactory()
@@ -165,7 +181,7 @@ test('basic prettifier tests', (t) => {
     }))
     log.info(true)
   })
-  
+
   t.test('can use different message keys', (t) => {
     t.plan(1)
     const pretty = prettyFactory({ messageKey: 'bar' })