Cache the pid and hostname globally, flatstr before writing #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
changed the title
|
Just need to update readme benchmarks?, |
|
Yours come out nicer (damn maxbook pro 15'') |
|
added benchmarks, we actually beat bole in every benchmark - but only just in some cases |
| @@ -72,52 +72,61 @@ This produces: | |||
| <a name="benchmarks"></a> | |||
| ## Benchmarks | |||
|
|
|||
| As far as we know, it is one of the fastest loggers in town: | |||
| As far as we know Pino is fastest logger in town. | |||
There was a problem hiding this comment.
I would leave this as before. The difference is so tiny, and the approach between bole and pino is essentially the same now.
20ms over 10000 log lines is hardly perceivable.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This put us on par with bole for basic and object benchmarks.
Inspired by https://github.com/rvagg/bole/blob/f3ba893c7f948f459615007767e2ffee519bc14c/bole.js#L13-L14.
^^ @rvagg good job!