[DellEMC] S52xx fix SFP reset in 1.0 API (sonic-net#4858)

Issue: Port with AOC cable does not come up when "sfputil reset <port_name>" is executed. Modified the incorrect mask used in reset API to resolve the issue.
pjaipakdee19 · Jul 7, 2020 · 92cd2c7 · 92cd2c7
1 parent 641d1ca
commit 92cd2c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/device/dell/x86_64-dellemc_s5232f_c3538-r0/plugins/sfputil.py b/device/dell/x86_64-dellemc_s5232f_c3538-r0/plugins/sfputil.py
@@ -193,7 +193,7 @@ def set_low_power_mode(self, port_num, lpmode):
         if (reg_value == "" ):
             return False
 
-        # Mask off 4th bit for presence
+        # Mask off 6th bit for lpmode
         mask = (1 << 6)
 
 	# LPMode is active high; set or clear the bit accordingly
@@ -224,7 +224,7 @@ def reset(self, port_num):
             return False
 
         # Mask off 4th bit for presence
-        mask = (1 << 6)
+        mask = (1 << 4)
 
         # ResetL is active low
         reg_value = reg_value & ~mask

diff --git a/device/dell/x86_64-dellemc_s5248f_c3538-r0/plugins/sfputil.py b/device/dell/x86_64-dellemc_s5248f_c3538-r0/plugins/sfputil.py
@@ -252,7 +252,7 @@ def set_low_power_mode(self, port_num, lpmode):
         if (reg_value == "" ):
             return False
 
-        # Mask off 4th bit for presence
+        # Mask off 6th bit for lpmode
         mask = (1 << 6)
 
 	# LPMode is active high; set or clear the bit accordingly
@@ -283,7 +283,7 @@ def reset(self, port_num):
             return False
 
         # Mask off 4th bit for presence
-        mask = (1 << 6)
+        mask = (1 << 4)
 
         # ResetL is active low
         reg_value = reg_value & ~mask