Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ipjsua swift sample app #3342

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Update ipjsua swift sample app #3342

merged 4 commits into from
Jun 16, 2023

Conversation

sauwming
Copy link
Member

@sauwming sauwming commented Jan 27, 2023 •
edited
Loading

  • Adjust video view to scale to fit while maintaining aspect ratio.
  • Fix iOS assertion: [MTLDebugDevice newTextureWithDescriptor:iosurface:plane:]:2469: failed assertion 'Texture Descriptor Validation IOSurface textures must use MTLStorageModeShared' by disabling Metal API Validation.
  • Increase default native codec Video Toolbox's video resolution and bitrate since devices are getting more powerful now.

@sauwming sauwming self-assigned this Jan 27, 2023
@sauwming sauwming added this to the release-2.14 milestone Jan 27, 2023
@sauwming sauwming mentioned this pull request Apr 3, 2023
Closed
@sauwming sauwming marked this pull request as draft May 10, 2023 02:14
@sauwming sauwming marked this pull request as ready for review May 10, 2023 02:15
@sauwming sauwming requested review from nanangizz and removed request for nanangizz May 10, 2023 02:15
@sauwming sauwming merged commit 0e89bbe into master Jun 16, 2023
@sauwming sauwming deleted the ipjsua-swift branch June 16, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trengginas trengginas trengginas approved these changes

@nanangizz nanangizz Awaiting requested review from nanangizz

Assignees

@sauwming sauwming

Labels
component: applications type: enhancement
Projects
None yet
Milestone
release-2.14
Development

Successfully merging this pull request may close these issues.
2 participants
@sauwming @trengginas