Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the configuration template file #8543

Open
jonasraoni opened this issue Jan 13, 2023 · 1 comment
Open

Review the configuration template file #8543

jonasraoni opened this issue Jan 13, 2023 · 1 comment
Assignees
@kaitlinnewson @pkp-dev-infrastructure
Labels
Try Me This issue might be good for a new contributor. Can you help us?
Milestone
3.3.0-20

Comments

@jonasraoni
Copy link
Contributor

jonasraoni commented Jan 13, 2023 •
edited
Loading

Describe the bug
The configuration across the applications shares most of the settings, but some of them seems to be missing a synchronization, e.g.:

The config of OMP has:
scheduled_tasks_report_error_only = On

The config of OJS has:
show_upgrade_warning = On
citation_checking_max_processes = 3
sitewide_privacy_statement = Off
:

It's needed to compare the settings across OJS/OMP/OPS for main and stable-3_3_0, and ensure the differences make sense.

Some settings seems to be not used:
[general].citation_checking_max_processes
[files].filename_revision_match
[curl].cainfo

What application are you using?
*/main
*/stable-3_3_0
@kaitlinnewson kaitlinnewson mentioned this issue Jul 29, 2024
Closed
@asmecher asmecher added this to the 3.3.0-19 milestone Jul 29, 2024
@asmecher asmecher added the Try Me This issue might be good for a new contributor. Can you help us? label Jul 29, 2024
@asmecher asmecher modified the milestones: 3.3.0-19, 3.3.0-20 Aug 16, 2024
@kaitlinnewson kaitlinnewson self-assigned this Aug 26, 2024
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Aug 30, 2024
@kaitlinnewson
pkp/pkp-lib#8543 sync config templates across applications
3173d3f
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Aug 30, 2024
@kaitlinnewson
pkp/pkp-lib#8543 sync config templates across applications
567c96c
kaitlinnewson added a commit to kaitlinnewson/ops that referenced this issue Aug 30, 2024
@kaitlinnewson
pkp/pkp-lib#8543 sync config templates across applications
924223e
kaitlinnewson added a commit to kaitlinnewson/ojs that referenced this issue Aug 30, 2024
@kaitlinnewson
pkp/pkp-lib#8543 sync config templates across applications
ae49ae0
kaitlinnewson added a commit to kaitlinnewson/ojs that referenced this issue Aug 30, 2024
@kaitlinnewson
pkp/pkp-lib#8543 remove unused config values
2c09701
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Aug 30, 2024
@kaitlinnewson
pkp/pkp-lib#8543 remove unused config values
eaef1a6
kaitlinnewson added a commit to kaitlinnewson/ops that referenced this issue Aug 30, 2024
@kaitlinnewson
pkp/pkp-lib#8543 remove unused config values
71c5173
@kaitlinnewson
Copy link
Member

PRs for 3.3 branches ready for review @asmecher:

Will work on forward-porting to 3.4/main once approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaitlinnewson kaitlinnewson

@pkp-dev-infrastructure pkp-dev-infrastructure

Labels
Try Me This issue might be good for a new contributor. Can you help us?
Projects
None yet
Milestone
3.3.0-20
Development

No branches or pull requests
4 participants
@asmecher @jonasraoni @kaitlinnewson @pkp-dev-infrastructure