Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#10319 update ORCID ui elements #406

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

taslangraham
Copy link
Contributor

@taslangraham taslangraham marked this pull request as ready for review September 4, 2024 19:03
: t('orcid.field.verification.request')
}}
</PkpButton>
<div style="display: inline-flex">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor, but I know we have started using some Tailwind in the ui library. @jardakotesovec for things like this, would you prefer a simple in-line style or doing the same thing via Tailwind classes? Or doesn't really matter?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For components that still have the BEM Less styling - you can either stick with BEM Less styling - or use tailwindcss. I personally have no problem if we have bit of mix for older components. It just should not be combination of both on one html element - than I think it gets quickly confusing.

Tailwindcss is pretty much inline styles, no need to use "style". In this case you could use class="inline-flex"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input @jardakotesovec, I'll update accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants