Skip to content

Commit

Permalink
Switch to NPM
Browse files Browse the repository at this point in the history
  • Loading branch information
trungleduc committed Mar 12, 2024
1 parent a748f64 commit f2fb726
Show file tree
Hide file tree
Showing 11 changed files with 6,732 additions and 6,570 deletions.
74 changes: 12 additions & 62 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,45 +15,15 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Install Conda environment with Micromamba
uses: mamba-org/setup-micromamba@v1
with:
environment-name: tljh
micromamba-version: "1.5.5-0"
init-shell: bash
create-args: >-
python=3.10
nodejs=18
yarn=3
- name: Setup pip cache
uses: actions/cache@v2
with:
path: ~/.cache/pip
key: pip-3.10-${{ hashFiles('setup.py') }}
restore-keys: |
pip-3.10-
pip-
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"

- name: Setup yarn cache
uses: actions/cache@v2
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: yarn-${{ hashFiles('./yarn.lock') }}
restore-keys: |
yarn-
- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Lint the application
shell: bash -l {0}
run: |
set -eux
yarn install
yarn run lint:check
npm install
npm run lint:check
- name: Package the application
shell: bash -l {0}
Expand All @@ -76,11 +46,8 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Install Python
uses: actions/setup-python@v4
with:
python-version: "3.10"
architecture: "x64"
- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -112,16 +79,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Set up Python ${{ matrix.python-version }}
uses: mamba-org/setup-micromamba@v1
with:
micromamba-version: "1.5.5-0"
environment-name: tljh
init-shell: bash
create-args: >-
python=${{ matrix.python-version }}
nodejs=18
yarn=3
- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Download app package
uses: actions/download-artifact@v3
Expand Down Expand Up @@ -153,17 +112,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Install Conda environment with Micromamba
uses: mamba-org/setup-micromamba@v1
with:
micromamba-version: "1.5.5-0"
environment-name: tljh
init-shell: bash
create-args: >-
python=3.10
nodejs=18
yarn=3
wget
- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Download app package
uses: actions/download-artifact@v3
Expand All @@ -183,14 +133,14 @@ jobs:
working-directory: ui-tests
env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
run: yarn install
run: npm install

- name: Set up browser cache
uses: actions/cache@v3
with:
path: |
${{ github.workspace }}/pw-browsers
key: ${{ runner.os }}-${{ hashFiles('ui-tests/yarn.lock') }}
key: ${{ runner.os }}-${{ hashFiles('ui-tests/package-lock.json') }}

- name: Install browser
shell: bash -l {0}
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ MANIFEST
config.yaml

# Frontend assets
.yarn
node_modules
dist/
ui-tests/playwright-report
Expand Down
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
**/package-lock.json
2 changes: 0 additions & 2 deletions .yarnrc.yml

This file was deleted.

2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Check out the official Docker documentation to know how to install Docker on you
Using `mamba` / `conda`:

```bash
mamba create -n tljh-repo2docker -c conda-forge python nodejs yarn=3
mamba create -n tljh-repo2docker -c conda-forge python nodejs
conda activate tljh-repo2docker
```

Expand Down
Loading

0 comments on commit f2fb726

Please sign in to comment.